Document aggregation code generation #121644
Conversation
idegtiarenko
added
>non-issue
Team:Analytics
| * As a result we could not rely on interfaces implementation and generics. | ||
| * </p> | ||
| * <p> | ||
| * In order to implement aggregation logic create your class (typically named "${FunctionName}${Type}Aggregator"). |
There was a problem hiding this comment.
The aggregator name format must be followed for it to work.
The AggregateMapper discovers it based on the name, with reflection, given the Function class name + the type:
So maybe we should rephrase this a bit? If the name has something unexpected, the AggregateMapper must be changed accordingly. Or maybe this isn't that important here anyway
There was a problem hiding this comment.
Yet more stuff not to like about AggregateMapper....
There was a problem hiding this comment.
After some thinking about this, and some sync with Ievgen, I'll try to remove AggMapper now. I think we can safely move the reflection to a Supplier method without "much" change. Let's see!
| * when both input type I and mutable accumulator state SS and GS are primitive (DOUBLE, INT). | ||
| * </li> | ||
| * <li>TBD explain {@code IntermediateState}</li> | ||
| * <li>TBD explain special internal state `seen`</li> |
There was a problem hiding this comment.
With the warnings feature, there's also the "failed" state. Identical to seen. Never used in main though, only here: https://github.com/elastic/elasticsearch/pull/116170/files#diff-8a408014887a6dc87eed1f71346536fc77636245d5411714b6ba2cf265812538R18
Maybe worth mentioning, with the warnExceptions attribute
| * Grouping aggregation expects: | ||
| * <ul> | ||
| * <li>type GS (a mutable state used to accumulate result of the grouping aggregation) to be public, not inner and implements {@link org.elasticsearch.compute.aggregation.GroupingAggregatorState}</li> | ||
| * <li>type I (input to your aggregation function), usually primitive types and {@link org.apache.lucene.util.BytesRef}</li> |
There was a problem hiding this comment.
I think you mean:
| * <li>type I (input to your aggregation function), usually primitive types and {@link org.apache.lucene.util.BytesRef}</li> | |
| * <li>type T (input to your aggregation function), usually primitive types and {@link org.apache.lucene.util.BytesRef}</li> |
From the following comments.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Update code generation documentation with Aggs method signatures expected to be seen/used by the generated code