Run cluster info requests on local node

docs/changelog/120982.yaml

@@ -0,0 +1,5 @@
+pr: 120982
+summary: Run cluster info requests on local node
+area: Indices APIs
+type: enhancement
+issues: []

docs/reference/indices/get-index.asciidoc

@@ -65,6 +65,6 @@ include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=include-defaults]
 If `false`, requests that target a missing index return an error. Defaults to
 `false`.
 
-include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=local]
+include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=local-deprecated-9.0.0]
 
 include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=master-timeout]

docs/reference/indices/get-mapping.asciidoc

@@ -54,7 +54,7 @@ Defaults to `open`.
 
 include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=index-ignore-unavailable]
 
-include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=local]
+include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=local-deprecated-9.0.0]
 
 include::{es-ref-dir}/rest-api/common-parms.asciidoc[tag=master-timeout]
 

qa/smoke-test-http/src/javaRestTest/java/org/elasticsearch/http/RestActionCancellationIT.java

@@ -15,6 +15,8 @@
 import org.elasticsearch.action.admin.cluster.settings.ClusterGetSettingsAction;
 import org.elasticsearch.action.admin.cluster.state.ClusterStateAction;
 import org.elasticsearch.action.admin.indices.alias.get.GetAliasesAction;
+import org.elasticsearch.action.admin.indices.get.GetIndexAction;
+import org.elasticsearch.action.admin.indices.mapping.get.GetMappingsAction;
 import org.elasticsearch.action.admin.indices.recovery.RecoveryAction;
 import org.elasticsearch.action.admin.indices.template.get.GetComponentTemplateAction;
 import org.elasticsearch.action.admin.indices.template.get.GetComposableIndexTemplateAction;
@@ -108,6 +110,16 @@ public void testGetPipelineCancellation() {
         runRestActionCancellationTest(new Request(HttpGet.METHOD_NAME, "/_ingest/pipeline"), GetPipelineAction.NAME);
     }
 
+    public void testGetIndexCancellation() {
+        createIndex("test");
+        runRestActionCancellationTest(new Request(HttpGet.METHOD_NAME, "/test"), GetIndexAction.NAME);
+    }
+
+    public void testGetMappingsCancellation() {
+        createIndex("test");
+        runRestActionCancellationTest(new Request(HttpGet.METHOD_NAME, "/test/_mappings"), GetMappingsAction.NAME);
+    }
+
     private void runRestActionCancellationTest(Request request, String actionName) {
         final var node = usually() ? internalCluster().getRandomNodeName() : internalCluster().startCoordinatingOnlyNode(Settings.EMPTY);
 

rest-api-spec/src/main/resources/rest-api-spec/api/ilm.explain_lifecycle.json

@@ -36,7 +36,7 @@
       },
       "master_timeout":{
         "type":"time",
-        "description":"Explicit operation timeout for connection to master node"
+        "description":"Timeout for waiting for new cluster state in case it is blocked"
       }
     }
   }

rest-api-spec/src/main/resources/rest-api-spec/api/indices.exists.json

@@ -27,6 +27,7 @@
     },
     "params":{
       "local":{
+        "deprecated":true,
         "type":"boolean",
         "description":"Return local information, do not retrieve the state from master node (default: false)"
       },

rest-api-spec/src/main/resources/rest-api-spec/api/indices.get.json

@@ -27,6 +27,7 @@
     },
     "params":{
       "local":{
+        "deprecated":true,
         "type":"boolean",
         "description":"Return local information, do not retrieve the state from master node (default: false)"
       },
@@ -71,7 +72,7 @@
       },
       "master_timeout":{
         "type":"time",
-        "description":"Specify timeout for connection to master"
+        "description":"Timeout for waiting for new cluster state in case it is blocked"
       }
     }
   }

rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_field_mapping.json

@@ -65,10 +65,6 @@
         ],
         "default":"open",
         "description":"Whether to expand wildcard expression to concrete indices that are open, closed or both."
-      },
-      "local":{
-        "type":"boolean",
-        "description":"Return local information, do not retrieve the state from master node (default: false)"
       }
     }
   }

rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_mapping.json

@@ -59,10 +59,7 @@
       "local":{
         "type":"boolean",
         "description":"Return local information, do not retrieve the state from master node (default: false)",
-        "deprecated":{
-          "version":"7.8.0",
-          "description":"This parameter is a no-op and field mappings are always retrieved locally."
-        }
+        "deprecated": true
       }
     }
   }

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/indices.exists/10_basic.yml

@@ -17,9 +17,14 @@
   - is_true: ''
 ---
 "Test indices.exists with local flag":
+  - requires:
+      test_runner_features: ["allowed_warnings"]
+
   - do:
       indices.exists:
         index: test_index
         local: true
+      allowed_warnings:
+        - "the [?local] query parameter to this API has no effect, is now deprecated, and will be removed in a future version"
 
   - is_false: ''

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/indices.get_field_mapping/10_basic.yml

@@ -50,17 +50,3 @@ setup:
 
   - match: {test_index.mappings.text.mapping.text.type:     text}
   - match: {test_index.mappings.text.mapping.text.analyzer: default}
-
----
-"Get field mapping with local parameter should fail":
-
-  - requires:
-      test_runner_features: ["warnings"]
-      cluster_features: ["gte_v8.0.0"]
-      reason: "local parameter for get field mapping API was allowed before v8"
-
-  - do:
-      catch: bad_request
-      indices.get_field_mapping:
-        fields: text
-        local: true

server/src/internalClusterTest/java/org/elasticsearch/action/IndicesRequestIT.java

@@ -24,8 +24,6 @@
 import org.elasticsearch.action.admin.indices.forcemerge.ForceMergeRequest;
 import org.elasticsearch.action.admin.indices.mapping.get.GetFieldMappingsAction;
 import org.elasticsearch.action.admin.indices.mapping.get.GetFieldMappingsRequest;
-import org.elasticsearch.action.admin.indices.mapping.get.GetMappingsAction;
-import org.elasticsearch.action.admin.indices.mapping.get.GetMappingsRequest;
 import org.elasticsearch.action.admin.indices.mapping.put.PutMappingRequest;
 import org.elasticsearch.action.admin.indices.mapping.put.TransportPutMappingAction;
 import org.elasticsearch.action.admin.indices.open.OpenIndexAction;
@@ -516,16 +514,6 @@ public void testDeleteIndex() {
         assertSameIndices(deleteIndexRequest, TransportDeleteIndexAction.TYPE.name());
     }
 
-    public void testGetMappings() {
-        interceptTransportActions(GetMappingsAction.NAME);
-
-        GetMappingsRequest getMappingsRequest = new GetMappingsRequest(TEST_REQUEST_TIMEOUT).indices(randomIndicesOrAliases());
-        internalCluster().coordOnlyNodeClient().admin().indices().getMappings(getMappingsRequest).actionGet();
-
-        clearInterceptedActions();
-        assertSameIndices(getMappingsRequest, GetMappingsAction.NAME);
-    }
-
     public void testPutMapping() {
         interceptTransportActions(TransportPutMappingAction.TYPE.name());
 

server/src/internalClusterTest/java/org/elasticsearch/cluster/SimpleClusterStateIT.java

@@ -266,7 +266,6 @@ public void testLargeClusterStatePublishing() throws Exception {
             MappingMetadata mappingMetadata = client.admin()
                 .indices()
                 .prepareGetMappings(TEST_REQUEST_TIMEOUT, "test")
-                .setLocal(true)
                 .get()
                 .getMappings()
                 .get("test");

server/src/main/java/org/elasticsearch/action/admin/indices/get/GetIndexRequest.java

@@ -17,16 +17,12 @@
 import org.elasticsearch.common.util.ArrayUtils;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.rest.RestRequest;
-import org.elasticsearch.tasks.CancellableTask;
-import org.elasticsearch.tasks.Task;
-import org.elasticsearch.tasks.TaskId;
 
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.EnumSet;
 import java.util.List;
 import java.util.Locale;
-import java.util.Map;
 import java.util.Set;
 
 /**
@@ -98,6 +94,10 @@ public GetIndexRequest(TimeValue masterTimeout) {
         super(masterTimeout, IndicesOptions.strictExpandOpen());
     }
 
+    /**
+     * Even though this action is executed on the local node, we still need to be able to read an incoming request as it's used across
+     * clusters.
+     */
     public GetIndexRequest(StreamInput in) throws IOException {
         super(in);
         features = in.readArray(i -> Feature.fromId(i.readByte()), Feature[]::new);
@@ -168,9 +168,4 @@ public void writeTo(StreamOutput out) throws IOException {
         out.writeBoolean(humanReadable);
         out.writeBoolean(includeDefaults);
     }
-
-    @Override
-    public Task createTask(long id, String type, String action, TaskId parentTaskId, Map<String, String> headers) {
-        return new CancellableTask(id, type, action, getDescription(), parentTaskId, headers);
-    }
 }

server/src/main/java/org/elasticsearch/action/admin/indices/get/TransportGetIndexAction.java

@@ -63,8 +63,7 @@ public TransportGetIndexAction(
             threadPool,
             actionFilters,
             GetIndexRequest::new,
-            indexNameExpressionResolver,
-            GetIndexResponse::new
+            indexNameExpressionResolver
         );
         this.indicesService = indicesService;
         this.settingsFilter = settingsFilter;

server/src/main/java/org/elasticsearch/action/admin/indices/mapping/get/GetMappingsRequest.java

@@ -14,19 +14,21 @@
 import org.elasticsearch.action.support.master.info.ClusterInfoRequest;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.core.TimeValue;
-import org.elasticsearch.tasks.CancellableTask;
-import org.elasticsearch.tasks.Task;
-import org.elasticsearch.tasks.TaskId;
+import org.elasticsearch.core.UpdateForV10;
 
 import java.io.IOException;
-import java.util.Map;
 
 public class GetMappingsRequest extends ClusterInfoRequest<GetMappingsRequest> {
 
     public GetMappingsRequest(TimeValue masterTimeout) {
         super(masterTimeout, IndicesOptions.strictExpandOpen());
     }
 
+    /**
+     * NB prior to 9.0 this was a TransportMasterNodeReadAction so for BwC we must remain able to read these requests until
+     * we no longer need to support calling this action remotely.
+     */
+    @UpdateForV10(owner = UpdateForV10.Owner.DATA_MANAGEMENT)
     public GetMappingsRequest(StreamInput in) throws IOException {
         super(in);
     }
@@ -35,9 +37,4 @@ public GetMappingsRequest(StreamInput in) throws IOException {
     public ActionRequestValidationException validate() {
         return null;
     }
-
-    @Override
-    public Task createTask(long id, String type, String action, TaskId parentTaskId, Map<String, String> headers) {
-        return new CancellableTask(id, type, action, "", parentTaskId, headers);
-    }
 }