Query Refactoring: Make EmptyQueryBuilder implement QueryBuilder directly #12072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly By extending AbstractQueryBuilder, EmptyQueryBuilder had setters for boost and queryname which defeats its original purpose of beeing a stand-in singleton for empty queries. By directly implementing QueryBuilder (and temporarily also extending ToXContentToBytes) this is prevented
|
LGTM |
cbuescher
added a commit
that referenced
this pull request
Jul 7, 2015
…xemptyqb Query Refactoring: Make EmptyQueryBuilder implement QueryBuilder directly
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring-fixemptyqb Query Refactoring: Make EmptyQueryBuilder implement QueryBuilder directly
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By extending AbstractQueryBuilder, EmptyQueryBuilder had setters for boost and
queryname which defeats its original purpose of beeing a stand-in
singleton for empty queries. By directly implementing QueryBuilder (and
temporarily also extending ToXContentToBytes) this is prevented
This PR is agains the query refactoring branch.