Adding endpoint creation validation to ElasticInferenceService #117642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
:ml
elasticsearchmachine
added
the
external-contributor
dan-rubinstein
removed
the
external-contributor
|
@elasticmachine merge upstream |
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @dan-rubinstein, I've created a changelog YAML for you. |
dan-rubinstein
added
v8.19.0
auto-backport
jonathan-buttner
approved these changes
Feb 19, 2025
I think that was a copy/paste issue. Although when EIS begins supporting text embedding we'll want to add it back so that we can get the accurate number of dimensions. |
|
@elasticmachine merge upstream |
💔 Backport failed
You can use sqren/backport to manually backport by running |
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Feb 19, 2025
…ic#117642) * Adding endpoint creation validation to ElasticInferenceService * Fix unit tests * Update docs/changelog/117642.yaml --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dan-rubinstein
added a commit
that referenced
this pull request
Feb 20, 2025
…) (#122956) * Adding endpoint creation validation to ElasticInferenceService * Fix unit tests * Update docs/changelog/117642.yaml --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces endpoint validation for EIS endpoints.
Question for the team before merging this change: Is there a reason we needed the
updateModelWithEmbeddingDetailsfunction? It seems that it just recreates the model with it's existing values so I have removed it in this change?Testing