[TEST] Migrated REST tests extending JsonLogsIntegTestCase #115188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REST tests extending JsonLogsIntegTestCase migrated to the new REST testing framework, using 'elasticsearch.internal-java-rest-test' Gradle plugin
jozala
added
>non-issue
>test
jozala
commented
Oct 21, 2024
| } | ||
| // TODO @jozala - not sure what to do about this --external--. Do we ever run against external clusters? | ||
| //tasks.named("javaRestTest").configure { | ||
| // dependsOn "assemble" // TODO @jozala - is this needed so that it uses the right distribution? Am I testing here with the expected distribution? |
There was a problem hiding this comment.
Is this special? Will the REST tests use the correct distribution without this configuration?
jozala
commented
Oct 21, 2024
Comment on lines
-33
to
-43
| assumeFalse( | ||
| "Skipping test because it is being run against an external cluster.", | ||
| logFile.getFileName().toString().equals("--external--") | ||
| ); | ||
| return AccessController.doPrivileged((PrivilegedAction<BufferedReader>) () -> { | ||
| try { | ||
| return Files.newBufferedReader(logFile, StandardCharsets.UTF_8); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I haven't recreated this behaviour. Do we run these tests against external clusters? Do we need this?
jozala
commented
Oct 21, 2024
Comment on lines
+39
to
+44
| .settingsModifier( | ||
| settings -> settings.entrySet() | ||
| .stream() | ||
| .filter(it -> it.getKey().equals("node.name") == false) | ||
| .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)) | ||
| ) |
There was a problem hiding this comment.
I've added this settings modifier in ClusterSpecBuilder to be able to remove node.name from configuration, but keep the rest of the Elasticsearch node setup working. I am wondering if there is already a better way to achieve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST tests extending JsonLogsIntegTestCase migrated to the new REST testing framework, using 'elasticsearch.internal-java-rest-test' Gradle plugin