Add refresh .security index call between security migrations #114879
+68
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreden
force-pushed
the
improve_sec_migration_framework
branch
from
ec5003c
to
127f6d2
Compare
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @jfreden, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: #110562
We're now adding more security migrations so we need to make sure that the framework handles migrations that depend on each other properly.
As part of that work we need to make sure that any subsequent migrations following a migration doesn't experience docs version conflicts, outdated docs or that APIs relying on migrated docs temporarily return the wrong results.
The security index currently relies on the
index.refresh_interval(defaults to 1s in stateful and 5s in stateless). See this PR: #97815This adds an explicit refresh before any migrations run and between migrations to make sure the index is refreshed when a migration starts.