Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChunkedToXContentHelper.array method, swap for Builder #114319

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Remove ChunkedToXContentHelper.array method, swap for Builder #114319

merged 9 commits into from
Oct 21, 2024
+197 −257

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Oct 8, 2024

No description provided.

@thecoop thecoop added :Core/Infra/Core Core issues without another label >refactoring v9.0.0 labels Oct 8, 2024
@thecoop
Copy link
Member Author

thecoop commented Oct 9, 2024

@elasticmachine update branch

@thecoop
Copy link
Member Author

thecoop commented Oct 10, 2024

@elasticmachine update branch

@thecoop thecoop marked this pull request as ready for review October 10, 2024 10:29
@thecoop thecoop requested a review from a team October 10, 2024 10:29
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Oct 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop thecoop force-pushed the array-chunked-xcontent-builder branch from 3491e5a to 355680e Compare October 16, 2024 13:23
ldematte
ldematte approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not sure I would change the Iterator in the *Decision.java classes, it is one of those cases where it looks more natural.

...r/src/main/java/org/elasticsearch/cluster/routing/allocation/AbstractAllocationDecision.java Outdated Show resolved Hide resolved
@thecoop thecoop added v8.17.0 auto-backport Automatically create backport pull requests when merged labels Oct 21, 2024
@thecoop thecoop merged commit 8c37875 into elastic:main Oct 21, 2024
16 checks passed
@thecoop thecoop deleted the array-chunked-xcontent-builder branch October 21, 2024 15:11
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114319

thecoop added a commit to thecoop/elasticsearch that referenced this pull request Oct 21, 2024
@thecoop
Remove ChunkedToXContentHelper.array method, swap for ChunkedToXConte…
fadeb05 
…ntBuilder (elastic#114319)
@thecoop thecoop mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecoop @elasticsearchmachine @ldematte @elasticmachine