Skip to content

Fix DocValuesCodecDuelTests #111503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix DocValuesCodecDuelTests #111503

merged 1 commit into from
Aug 1, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Aug 1, 2024

We should not access any docValues attribute of the current document if advance() is exhausted or if advanceExact() returns false.

Closes #111470

@dnhatn dnhatn added :StorageEngine/TSDB You know, for Metrics >test Issues or PRs that are addressing/adding tests v8.15.1 auto-backport-and-merge labels Aug 1, 2024
@dnhatn dnhatn requested review from kkrik-es and lkts August 1, 2024 04:34
@dnhatn dnhatn marked this pull request as ready for review August 1, 2024 04:34
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn
Copy link
Member Author

dnhatn commented Aug 1, 2024

Thanks @kkrik-es.

@dnhatn dnhatn merged commit 63c2dde into elastic:main Aug 1, 2024
15 checks passed
@dnhatn dnhatn deleted the fix-duel-test branch August 1, 2024 13:53
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Aug 1, 2024
We should not access any docValues attribute of the current document if 
advance() is exhausted or if advanceExact() returns false.

Closes elastic#111470
elasticsearchmachine pushed a commit that referenced this pull request Aug 1, 2024
We should not access any docValues attribute of the current document if 
advance() is exhausted or if advanceExact() returns false.

Closes #111470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DocValuesCodecDuelTests testDuel failing
3 participants