ES|QL: reduce max expression depth to 400 #111186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>bug
auto-backport-and-merge
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
nik9000
approved these changes
Jul 23, 2024
💚 Backport successful
|
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Jul 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing limit of 500 was too close to the actual stack limit, so it still triggered sporadic StackOverflowErrors in CI.
StackOverflowErrors are handled in the parser, but in a much less graceful way, so it's much preferable to have a reliable way to limit the expression depth in advance.
With this change we reduce the limit to 400, that is still reasonable for real use cases, but much more safe against SOE
Fixes #109846