A small tidiness refactor of the GeoIpTaskState's Metadata #110553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to get the loosely-typed dynamic bits away from the statically typed reliable bits.
joegallo
added
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Jul 8, 2024
💚 Backport successful
|
joegallo
added a commit
that referenced
this pull request
Jul 8, 2024
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 11, 2024
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more changes coming down the pipe, but this seemed like a reasonably small unit of work that was worth reviewing and getting out of my local WIP.
It drops the
.contains(...)and.get(...)methods ofGeoIpTaskState, favoring just asking questions of the underlying databases directly. Then, using a well-appliedgetOrDefault(...)the code gets a bit simpler. Finally it splits off the map-y dynamic code from the rest of the logic. Overall I find this version easier to follow.