Introduce compute listener #110400
Merged
Introduce compute listener #110400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
compute-listener
branch
5 times, most recently
from
fb4657b
to
b560b5a
Compare
|
Hi @dnhatn, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
reviewed
Jul 3, 2024
There was a problem hiding this comment.
👍 on collecting the listener behavior into a named class.
Do you think it's appropriate to pull that class into it's own top level file? Do you think it's appropriate to make a test case specifically for it?
I know this has been quite the distraction and I'm proposing more distractions, but the listener behavior is pretty complex and a test might help other people to hold it in their head.
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| /** | ||
| * Collects exceptions occurred in compute, specifically ignores trivial exceptions such as {@link TaskCancelledException}, |
There was a problem hiding this comment.
The comment isn't quite right I think - if there aren't any exceptions captured it'll capture the first "trivial exception". And it'll replace that with the first non-trivial exception it sees.
| if (ExceptionsHelper.unwrapCause(first) != ExceptionsHelper.unwrapCause(e)) { | ||
| if (exceptionPermits.tryAcquire()) { | ||
| first.addSuppressed(e); | ||
| } |
There was a problem hiding this comment.
getAndUpdate is documented as requiring a side-effect-free function because it'll be retried sometimes. I think this is safe, but it's not really side effect free. Maybe it'd be more readable if we used an atomicarray or something. Either way, I spent a while reading this code and thinking about it, but I don't think the performance is all that critical here because it's deep into exception path.
|
@nik9000 Thank you for the feedback. I have made the ComputeLister its own class and added tests for it. I also updated the javadoc and implementation of FailureCollector to use concurrent queues. This should be ready for review again. Could you please take another look? |
nik9000
approved these changes
Jul 5, 2024
|
Thanks Nik! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 5, 2024
Currently, if a child request fails, we automatically trigger cancellation for ES|QL requests. This can result in TaskCancelledException being collected by the RefCountingListener first, which then returns that exception to the caller. For example, if we encounter a CircuitBreakingException (429), we might incorrectly return a TaskCancelledException (400) instead. This change introduces the ComputeListener, a variant of RefCountingListener, which selects the most appropriate exception to return to the caller. I also integrated the following features into ComputeListener to simplify ComputeService: - Automatic cancellation of sub-tasks on failure. - Collection of profiles from sub-tasks. - Collection of response headers from sub-tasks.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 5, 2024
Currently, if a child request fails, we automatically trigger cancellation for ES|QL requests. This can result in TaskCancelledException being collected by the RefCountingListener first, which then returns that exception to the caller. For example, if we encounter a CircuitBreakingException (429), we might incorrectly return a TaskCancelledException (400) instead. This change introduces the ComputeListener, a variant of RefCountingListener, which selects the most appropriate exception to return to the caller. I also integrated the following features into ComputeListener to simplify ComputeService: - Automatic cancellation of sub-tasks on failure. - Collection of profiles from sub-tasks. - Collection of response headers from sub-tasks.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 5, 2024
Currently, if a child request fails, we automatically trigger cancellation for ES|QL requests. This can result in TaskCancelledException being collected by the RefCountingListener first, which then returns that exception to the caller. For example, if we encounter a CircuitBreakingException (429), we might incorrectly return a TaskCancelledException (400) instead. This change introduces the ComputeListener, a variant of RefCountingListener, which selects the most appropriate exception to return to the caller. I also integrated the following features into ComputeListener to simplify ComputeService: - Automatic cancellation of sub-tasks on failure. - Collection of profiles from sub-tasks. - Collection of response headers from sub-tasks.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 6, 2024
Currently, if a child request fails, we automatically trigger cancellation for ES|QL requests. This can result in TaskCancelledException being collected by the RefCountingListener first, which then returns that exception to the caller. For example, if we encounter a CircuitBreakingException (429), we might incorrectly return a TaskCancelledException (400) instead. This change introduces the ComputeListener, a variant of RefCountingListener, which selects the most appropriate exception to return to the caller. I also integrated the following features into ComputeListener to simplify ComputeService: - Automatic cancellation of sub-tasks on failure. - Collection of profiles from sub-tasks. - Collection of response headers from sub-tasks.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 8, 2024
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 9, 2024
ComputeResponse from old nodes may have a null value instead of an empty list for profiles. Relates elastic#110400 Closes elastic#110591
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 9, 2024
ComputeResponse from old nodes may have a null value instead of an empty list for profiles. Relates elastic#110400 Closes elastic#110591
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 9, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a child request fails, we automatically trigger cancellation for ES|QL requests. This can result in TaskCancelledException being collected by the RefCountingListener first, which then returns that exception to the caller. For example, if we encounter a CircuitBreakingException (429), we might incorrectly return a TaskCancelledException (400) instead.
This change introduces the ComputeListener, a variant of RefCountingListener, which ignores unimportant exceptions and selects the most appropriate exception to return to the caller. I also integrated the following features into ComputeListener to simplify ComputeService: