Skip to content

[8.12] Always show composed_of field for composable index templates (#105315) #105571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Feb 15, 2024

Backports the following commits to 8.12:

…ic#105315)

* Always show `composed_of` field for composable index templates

Prior to e786cfa we inadvertently always added composable index
templates with `composed_of: []` beacuse
elastic@e786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630
created a new `ComposableIndexTemplate` from an existing one, and the `.composedOf()` field returned
an empty list of no component templates were provided:

https://github.com/elastic/elasticsearch/blob/89e714ee5dc60db8b4979ab6372ff767e108e9da/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java#L172-L177

This meant that before 8.12.0 we would always show `composed_of: []` for composable index templates.
This commit recreates this behavior, and always displays the empty list even if no component
templates are used by a composable index template.

Resolves elastic#104627
@dakrone dakrone added :Data Management/Indices APIs APIs to create and manage indices and templates >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Data Management Meta label for data/management team labels Feb 15, 2024
@elasticsearchmachine elasticsearchmachine merged commit c85ce02 into elastic:8.12 Feb 15, 2024
@dakrone dakrone deleted the backport/8.12/pr-105315 branch February 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v8.12.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants