Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix issue with invalid format of operational LDAP attributes #105345

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Feb 9, 2024

This PR disables generating operational LDAP server attributes (like createTimestamp and modifyTimestamp).
The format of these attributes is dependent on the locale and can violate the default schema format.
We don't depend on these attributes in any of our AD/LDAP tests.

Resolves #105310

This PR disables generating operational LDAP server attributes (like
createTimestamp or modifyTimestamp) whose format is dependent on the
locale and can cause invalid format failures since they can violate
the default schema.

We don't depend nor use these attributes in any of our AD/LDAP tests.
@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team labels Feb 9, 2024
@slobodanadamovic slobodanadamovic self-assigned this Feb 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Interesting...

@slobodanadamovic slobodanadamovic merged commit c6808d0 into elastic:main Feb 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] LdapRealmReloadTests testReloadWithoutConnectionPool failing
3 participants