Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention IndexFormatToo{Old,New}Exception as corruption #104204

Conversation

DaveCTurner
Copy link
Contributor

If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.

If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. auto-backport-and-merge v8.12.1 v8.13.0 v8.11.5 labels Jan 10, 2024
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team labels Jan 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@@ -50,8 +57,7 @@ system previously confirmed to {es} that this file was durably synced to disk.
On Linux this means that the `fsync()` system call returned successfully. {es}
sometimes reports that an index is corrupt because a file needed for recovery
is missing, or it exists but has been truncated or is missing its footer. This
indicates that your storage system acknowledges durable writes incorrectly or
that some external process has modified the data {es} previously wrote to disk.
may indicate that your storage system acknowledges durable writes incorrectly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this change is related to the title. Was it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was intentional, I meant to fix this in the last change to this file but missed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you like to remove the mention of another process? My understanding is that it is still a possibility. Is it mentioned anywhere else?

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 10, 2024
@elasticsearchmachine elasticsearchmachine merged commit 312d4c2 into elastic:main Jan 10, 2024
7 checks passed
@DaveCTurner DaveCTurner deleted the 2024/01/10/IndexFormatTooOldException-corruption branch January 10, 2024 13:54
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jan 10, 2024
)

If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jan 10, 2024
)

If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.12
8.11

elasticsearchmachine pushed a commit that referenced this pull request Jan 10, 2024
…104207)

If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.
elasticsearchmachine pushed a commit that referenced this pull request Jan 10, 2024
…104208)

If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.
@DaveCTurner DaveCTurner restored the 2024/01/10/IndexFormatTooOldException-corruption branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team v8.11.5 v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants