Expose realms authentication metrics #104200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authentications for individual realms. Exposed metrics are: - `es.security.authc.realms.success.total` - `es.security.authc.realms.failures.total` - `es.security.authc.realms.time` Each of the metric is exposed at node level and includes additional information with these attributes: - `es.security.realm_type` - `es.security.realm_name` - `es.security.realm_authc_failure_reason`
slobodanadamovic
added
>enhancement
:Security/Authentication
|
Hi @slobodanadamovic, I've created a changelog YAML for you. |
| "Authentication of [%s] was terminated by realm [%s] - %s", | ||
| realm.authenticate( | ||
| authenticationToken, | ||
| InstrumentedSecurityActionListener.wrapForAuthc(authenticationMetrics, realm, ActionListener.wrap(result -> { |
There was a problem hiding this comment.
Wrapping a listener with InstrumentedSecurityActionListener.wrapForAuthc caused the formatting change which makes it hard to determine the actual diff, but this line is the only change.
…bodanadamovic/elasticsearch into sa-add-realms-authentication-metrics
…ealms-authentication-metrics
…ealms-authentication-metrics
…ealms-authentication-metrics # Conflicts: # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/metric/SecurityMetricType.java
…ealms-authentication-metrics
|
Pinging @elastic/es-security (Team:Security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics for recording successful and failed
authentications for individual realms. Exposed metrics are:
es.security.authc.realms.success.totales.security.authc.realms.failures.totales.security.authc.realms.timeEach of the metric is exposed at node level and includes additional information with these attributes:
es.security.realm_type- can be one of:jwt,saml,oidc,active_directory,ldap,pki,kerberos...es.security.realm_namees.security.realm_authc_failure_reason