Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version-specific helper for poison pills #101767

Merged
merged 12 commits into from
Nov 15, 2023
Merged

Create version-specific helper for poison pills #101767

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
833553a
Add static assertRemoveBeforeV9()
ldematte Nov 3, 2023
dc29115
Javadoc
ldematte Nov 3, 2023
bdcf75b
Introducing remove annotation + some usage examples
ldematte Nov 3, 2023
c9d37de
spotless
ldematte Nov 3, 2023
b0e0a30
Update docs/changelog/101767.yaml
ldematte Nov 3, 2023
a9ce68c
Fixup ReplicationTracker
DaveCTurner Nov 3, 2023
64b5f21
Merge remote-tracking branch 'upstream/main' into assert-poison-pill
ldematte Nov 14, 2023
148d36d
Merge branch 'assert-poison-pill' of github.com:ldematte/elasticsearc…
ldematte Nov 14, 2023
f2e2cb9
remove changelog
ldematte Nov 14, 2023
defcfad
Rename
ldematte Nov 14, 2023
35664b5
Merge remote-tracking branch 'upstream/main' into assert-poison-pill
ldematte Nov 14, 2023
5d5e900
Update name, use annotation on fields
ldematte Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Javadoc
  • Loading branch information
@ldematte
ldematte committed Nov 3, 2023
commit dc29115690d8c36894be43c756d9255816b935b9
5 changes: 3 additions & 2 deletions libs/core/src/main/java/org/elasticsearch/core/Assertions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ private Assertions() {}
/**
* A "poison-pill" assertion to use in code we want to review (cleanup, remove or change) before releasing 9.0
* Before starting the 9.0 release process a feature branch will be created, in which this assertion will be changed to cause failures
* which must addressed before to main.
* Each poison pill has to be addressed before we can merge to main, branch the next version and bump the current version.
* which must addressed before proceeding.
* Each poison pill has to be addressed before we merge the feature branch to main. Only then we can proceed to branch the next version
* and bump the current version.
* @param reason a string that will be part of the assertion message, with details on how to fix the issue.
*/
public static void assertRemoveBeforeV9(String reason) {
Expand Down