Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string version internally for PluginDescriptor #100713

Merged
merged 16 commits into from
Oct 17, 2023
Merged

Use string version internally for PluginDescriptor #100713

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
76e5b5c
PluginDescriptor uses string version internally
williamrandolph Oct 4, 2023
d3c27d6
Update serialization
williamrandolph Oct 4, 2023
42140ce
Merge branch 'main' into version/plugin-descriptor-internal
williamrandolph Oct 11, 2023
837b295
Cleanup todos
williamrandolph Oct 11, 2023
62c23ba
Fix bogus version test
williamrandolph Oct 11, 2023
2551756
Test cleanup
williamrandolph Oct 11, 2023
774eb7b
fix compile failure
williamrandolph Oct 11, 2023
9fb7024
Fix serialization test
williamrandolph Oct 11, 2023
eaad6f6
Merge branch 'main' into version/plugin-descriptor-internal
williamrandolph Oct 11, 2023
0467504
Respond to PR feedback
williamrandolph Oct 13, 2023
e5f91db
Change random value in test
williamrandolph Oct 13, 2023
fd3f07f
Merge branch 'main' into version/plugin-descriptor-internal
williamrandolph Oct 13, 2023
9f82c0f
Handle null esVersion
williamrandolph Oct 13, 2023
fb6ebbd
Remove Version validation
williamrandolph Oct 17, 2023
a2710f1
Merge branch 'main' into version/plugin-descriptor-internal
williamrandolph Oct 17, 2023
fdd468c
Change random test value
williamrandolph Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into version/plugin-descriptor-internal
  • Loading branch information
@williamrandolph
williamrandolph committed Oct 13, 2023
commit fd3f07f90b49deee98b6203548a83c71672a2f2c
5 changes: 3 additions & 2 deletions server/src/main/java/org/elasticsearch/TransportVersions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,9 @@ static TransportVersion def(int id) {
public static final TransportVersion PLUGIN_DESCRIPTOR_OPTIONAL_CLASSNAME = def(8_513_00_0);
public static final TransportVersion UNIVERSAL_PROFILING_LICENSE_ADDED = def(8_514_00_0);
public static final TransportVersion ELSER_SERVICE_MODEL_VERSION_ADDED = def(8_515_00_0);
public static final TransportVersion PLUGIN_DESCRIPTOR_STRING_VERSION = def(8_516_00_0);

public static final TransportVersion NODE_STATS_HTTP_ROUTE_STATS_ADDED = def(8_516_00_0);
public static final TransportVersion INCLUDE_SHARDS_STATS_ADDED = def(8_517_00_0);
public static final TransportVersion PLUGIN_DESCRIPTOR_STRING_VERSION = def(8_518_00_0);
/*
* STOP! READ THIS FIRST! No, really,
* ____ _____ ___ ____ _ ____ _____ _ ____ _____ _ _ ___ ____ _____ ___ ____ ____ _____ _
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.