Don't use an asserting searcher at all in MatchingDirectoryReader #100668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>test
|
Pinging @elastic/es-search (Team:Search) |
ywangd
approved these changes
Oct 11, 2023
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Oct 11, 2023
…astic#100668) Follow up to elastic#100527 We are not testing anything to do with searching with this searcher, and so there is no point in using LuceneTestCase.newSearcher() which will wrap it with all sorts of extra checks that may access the underlying reader in ways that are not anticipated by tests. Fixes elastic#100460 Fixes elastic#99024
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2023
…00668) (#100685) Follow up to #100527 We are not testing anything to do with searching with this searcher, and so there is no point in using LuceneTestCase.newSearcher() which will wrap it with all sorts of extra checks that may access the underlying reader in ways that are not anticipated by tests. Fixes #100460 Fixes #99024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #100527
We are not testing anything to do with searching with this searcher, and so
there is no point in using
LuceneTestCase.newSearcher()which will wrapit with all sorts of extra checks that may access the underlying reader in
ways that are not anticipated by tests.
Fixes #100460
Fixes #99024