Propagate cancellation in DataTiersUsageTransportAction #100253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action invokes a subsidiary action but does not set up the proper parent/child relationship, so cancellations of the parent task do not propagate to the child. Relates elastic#100230
DaveCTurner
added
>bug
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
approved these changes
Oct 4, 2023
| @@ -74,7 +75,7 @@ protected void masterOperation( | |||
| ClusterState state, | |||
| ActionListener<XPackUsageFeatureResponse> listener | |||
| ) { | |||
| client.admin() | |||
| new ParentTaskAssigningClient(client, clusterService.localNode(), task).admin() | |||
There was a problem hiding this comment.
TIL about ParentTaskAssigningClient
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action invokes a subsidiary action but does not set up the proper
parent/child relationship, so cancellations of the parent task do not
propagate to the child.
Relates #100230