Skip to content

Most of SLM Snapshot Orchestration can be Removed #59655

Closed
@original-brownbear

Description

@original-brownbear

With #56911 merged to 7.9 and newer, all code in SLM dedicated to making sure that multiple snapshots or snapshot deletes don't run at the same time has become obsolete.
We should move this logic to a separate BwC path to be used in a mixed version cluster and otherwise short-circuit all the checks and waiting and simply execute all operations exactly as scheduled since they will always work out now without exception.

This will make SLM a lot more predictable in behavior since things like slow snapshots will stop causing hold-ups for deletes or other snapshots. Another obvious benefit would be that we will never redundantly load all the SnapshotInfo to determine what snapshots to delete since deletes would never collide/wait/fail.

Somewhat relates to #56082 which is another possible optimization to SLM enabled by recent snapshot changes

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions