Skip to content

Rework AckIT tests #33673

Closed
Closed
@ywelsch

Description

@ywelsch

#30672 fixed the acking mechanism in Elasticsearch, which would previously just erroneously report failures as successful acks. The AckIT tests that accompanied the acking implementation are unfortunately fundamentally broken and would have never worked if the acking implementation had not been broken since its inception. The reason that the acking cannot work in this class is that it uses a publish timeout of 0, which can result in cluster states to arrive out-of-order on nodes, which can in certain situations lead to cluster states being rejected as a better cluster state was already fully applied on the node. One way to work around the limitations in the test here might be to bring the cluster to a stable state first, and only then change the publish timeout for the one publishing round we want to check the acking for.

The AckIT tests have been disabled as part of #32767 and should be reworked / possibly replaced by a new set of tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    :Distributed Indexing/DistributedA catch all label for anything in the Distributed Indexing Area. Please avoid if you can.help wantedadoptme

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions