Skip to content

Params: ignore unbound parameters #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Mar 17, 2020

Unbound parameters are allowed by the standard and there's a
mechanism that allows the application to signal the driver which
parameters to ignore. There are applications however that set certain
attributes of a first parameter (despite the query containing no
markers), that still don't use this mechanism.

This PR will have the driver ignore parameters with attributes set
by the application, but not bound, as long as these unbound ones don't
show up before the contiguous list of bound parameters.

Unbound parameters are allowed by the standard, although there's a
mechanism that allows the application to signal the driver which
parameters to ignore. There are appliacations however that set certain
attributes of a first parameter (despite the query containing no
markers), that however don't use this mechanism.

This commit will have the driver ignore parameters with attributes set
by the application, but not bound, as long as these unbound ones don't
show up before the contiguous list of bound ones.
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit c39cb37 into elastic:master Mar 17, 2020
@bpintea bpintea deleted the fix/ignore_not_bound_param branch March 17, 2020 23:59
bpintea added a commit that referenced this pull request Mar 18, 2020
Unbound parameters are allowed by the standard, although there's a
mechanism that allows the application to signal the driver which
parameters to ignore. There are appliacations however that set certain
attributes of a first parameter (despite the query containing no
markers), that however don't use this mechanism.

This commit will have the driver ignore parameters with attributes set
by the application, but not bound, as long as these unbound ones don't
show up before the contiguous list of bound ones.

(cherry picked from commit c39cb37)
@bpintea bpintea added the v7.8.0 label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants