Skip to content

Fixes: possible buffer overrun on interval conversion. Catalog length handling #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2020
Merged

Fixes: possible buffer overrun on interval conversion. Catalog length handling #217

merged 2 commits into from
Mar 17, 2020

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Mar 11, 2020 •
edited by droberts195
Loading

This PR fixes two low-probability/impact defects:

  • when converting a bound parameter from string to an interval type, the destination buffer lacked space for the 0-terminator, which was nevertheless written. This was triggered by unit testing; this functionality has a very low use probability.
  • the recently added support for setting the current catalog came with a defect in the way the catalog (wide) string length was considered: character count vs. the normed byte count. That's now being corrected. This leads to the API call failure, but applications tend to ignore it, thus a low impact.

bpintea added 2 commits March 11, 2020 20:42
@bpintea
fix overrun when converting a c-string to interval
a17d8f3 
When converting a C-string to a wide string, the conversion function
0-terminates the output. However, the allocated destination buffer
lacked the space for the terminator. This commit fixes that.
@bpintea
fix catalog setting
4c3c717 
The API function provides the byte count for the wide string name of the
catalog, not the character count, as so far implemented. This commit
fixes the lenght handling.
@bpintea bpintea requested review from droberts195 and edsavage March 11, 2020 20:05
@droberts195 droberts195 added v6.8.8 and removed v6.8.7 labels Mar 16, 2020
droberts195
droberts195 approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit e390375 into elastic:master Mar 17, 2020
@bpintea bpintea deleted the fix/str_to_interval_buff_overrun branch March 17, 2020 22:17
bpintea added a commit that referenced this pull request Mar 17, 2020
@bpintea
Fixes: possible buffer overrun on interval conversion. Catalog length…
a45395b 
… handling (#217)

* fix overrun when converting a c-string to interval

When converting a C-string to a wide string, the conversion function
0-terminates the output. However, the allocated destination buffer
lacked the space for the terminator. This commit fixes that.

* fix catalog setting

The API function provides the byte count for the wide string name of the
catalog, not the character count, as so far implemented. This commit
fixes the lenght handling.

(cherry picked from commit e390375)
bpintea added a commit that referenced this pull request Mar 17, 2020
@bpintea
Fixes: possible buffer overrun on interval conversion. Catalog length…
db3cde3 
… handling (#217)

* fix overrun when converting a c-string to interval

When converting a C-string to a wide string, the conversion function
0-terminates the output. However, the allocated destination buffer
lacked the space for the terminator. This commit fixes that.

* fix catalog setting

The API function provides the byte count for the wide string name of the
catalog, not the character count, as so far implemented. This commit
fixes the lenght handling.

(cherry picked from commit e390375)
bpintea added a commit that referenced this pull request Mar 17, 2020
@bpintea
Fixes: possible buffer overrun on interval conversion. Catalog length…
f5caffc 
… handling (#217)

* fix overrun when converting a c-string to interval

When converting a C-string to a wide string, the conversion function
0-terminates the output. However, the allocated destination buffer
lacked the space for the terminator. This commit fixes that.

* fix catalog setting

The API function provides the byte count for the wide string name of the
catalog, not the character count, as so far implemented. This commit
fixes the lenght handling.

(cherry picked from commit e390375)
@bpintea bpintea mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

@edsavage edsavage Awaiting requested review from edsavage

Assignees
No one assigned
Labels
>bug v6.8.8 v7.6.2 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpintea @droberts195