Skip to content

Add support for doc_id #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

Add support for doc_id #732

merged 1 commit into from
Sep 15, 2021

Conversation

delvedor
Copy link
Member

As titled.

Closes: #714.

@delvedor delvedor requested review from lcawl and a team September 14, 2021 07:04
swallez
swallez approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll see how to resolve those ids into URLs once they start landing in the spec.

lcawl
lcawl approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@delvedor delvedor merged commit da0b162 into main Sep 15, 2021
@delvedor delvedor deleted the feat-714 branch September 15, 2021 09:51
github-actions bot pushed a commit that referenced this pull request Sep 15, 2021
@delvedor @github-actions
Add support for doc_id (#732)
6810a53
@github-actions github-actions bot mentioned this pull request Sep 15, 2021
Merged
@lcawl lcawl mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc URL keywords
3 participants
@delvedor @swallez @lcawl