Skip to content

[Backport 8.19] Add more instructions against PRs from forks #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Documents under the docs/ directory will help you to change the specification. T
* [Fixing a definition, the complete story](docs/validation-example.md)


## Send your pull request
## Send your pull request from a branch

To fix any style issues and generate the outputs (that we store in git), please run:

Expand All @@ -56,5 +56,4 @@ Then, follow those steps:
- If the API is unusable without the change -> every supported version
- If the API is usable, but fix is on the response side -> every supported version
- If the API is usable, but fix is on the request side -> no backport, unless the API is _partially_ usable and the fix unlocks a missing feature that has no workaround


- Send the pull request from a branch, **not a fork**
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ If you need to download the recordings again, run `make validate-no-cache api=xp

Once you see the errors, you can fix the original definition in `/specification`
and then run the command again until the types validator does not trigger any new error.
Finally open a pull request with your changes.
Finally open a pull request with your changes. Please open it from a branch in the repository, and not from a fork.

## Documentation

Expand Down