Skip to content

Fixing nodes info response #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2025
Merged

Fixing nodes info response #4636

merged 5 commits into from
Jun 30, 2025

Conversation

l-trotta
Copy link
Contributor

From 1/112 validated responses to 112/112. Details:

  • Missing fields in NodeInfo -> server code
  • transport.ignore_deserialization_errors is said to be only used in unit tests, so I'm setting it as private -> server code
  • In NodeJvmInfo, bundled_jdk is not actually there, there's only using_bundled_jdk -> server code

@l-trotta l-trotta force-pushed the fixing-nodes-info-resp branch from b37952d to 902b212 Compare June 20, 2025 09:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

Following you can find the validation changes for the API you have modified.

API Status Request Response
nodes.info 🔴 → 🟢 112/112 1/112 → 112/112

You can validate this API yourself by using the make validate target.

@l-trotta l-trotta mentioned this pull request Jun 23, 2025
Open
pquentin
pquentin reviewed Jun 30, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In NodesInfo:

l-trotta and others added 3 commits June 30, 2025 16:25
@l-trotta
Copy link
Contributor Author

In NodesInfo:

* It looks like `remote_cluster_server` is missing? See [NodesInfoResponse.java](https://github.com/elastic/elasticsearch/blob/b2acda9a9fe150cb643ff07da93d15d00a9c58a3/server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoResponse.java#L118C34-L120) and [RemoteClusterServerInfo.java](https://github.com/elastic/elasticsearch/blob/5b9b0339ed809787b88e66d1062b6e2e167715d4/server/src/main/java/org/elasticsearch/transport/RemoteClusterServerInfo.java#L34-L47).

* `network` was removed in 2.0: [Remove network stats & info elasticsearch#12054](https://github.com/elastic/elasticsearch/pull/12054)

added and removed, thank you! it's likely that fields like remote_cluster_server are missing from other responses like nodes.cluster, I'll merge this first and then go on with fixing other apis.

pquentin
pquentin approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@l-trotta l-trotta merged commit 36e78a1 into main Jun 30, 2025
8 checks passed
@l-trotta l-trotta deleted the fixing-nodes-info-resp branch June 30, 2025 15:11
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@l-trotta @pquentin @github-actions
Fixing nodes info response (#4636)
cdfa7a2 
* fix node info res

* Update specification/nodes/info/types.ts

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>

* address review

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 36e78a1)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@l-trotta @pquentin @github-actions
Fixing nodes info response (#4636)
3cefa3c 
* fix node info res

* Update specification/nodes/info/types.ts

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>

* address review

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 36e78a1)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@l-trotta @pquentin @github-actions
Fixing nodes info response (#4636)
e742eee 
* fix node info res

* Update specification/nodes/info/types.ts

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>

* address review

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 36e78a1)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@l-trotta @pquentin @github-actions
Fixing nodes info response (#4636)
a86ebe0 
* fix node info res

* Update specification/nodes/info/types.ts

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>

* address review

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 36e78a1)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
l-trotta added a commit that referenced this pull request Jun 30, 2025
@github-actions @l-trotta @pquentin
Fixing nodes info response (#4636) (#4720)
7bce598 
* fix node info res

* Update specification/nodes/info/types.ts



* address review

---------


(cherry picked from commit 36e78a1)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
l-trotta added a commit that referenced this pull request Jun 30, 2025
@github-actions @l-trotta @pquentin
Fixing nodes info response (#4636) (#4719)
9c2c997 
* fix node info res

* Update specification/nodes/info/types.ts



* address review

---------


(cherry picked from commit 36e78a1)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
l-trotta added a commit that referenced this pull request Jun 30, 2025
@github-actions @l-trotta @pquentin
Fixing nodes info response (#4636) (#4718)
9db3704 
* fix node info res

* Update specification/nodes/info/types.ts



* address review

---------


(cherry picked from commit 36e78a1)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
l-trotta added a commit that referenced this pull request Jun 30, 2025
@github-actions @l-trotta @pquentin
Fixing nodes info response (#4636) (#4717)
7fdcf7b 
* fix node info res

* Update specification/nodes/info/types.ts



* address review

---------


(cherry picked from commit 36e78a1)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.18 backport 8.19 backport 9.0 backport 9.1 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-trotta @pquentin