-
Notifications
You must be signed in to change notification settings - Fork 102
Backport x-codeSamples
changes to 8.19
#4603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a preview of the output and docs LGTM, thanks!
* add request heading line to request examples * add request heading line to response examples * changes to the compiler to include the request heading
* add a few example requests for endpoints that do not use bodies * Remove x-codeSamples from overlay * restructure existing examples w/o bodies as request examples * skip examples w/o bodies when generating openapi examples * add a lot of missing examples * remove duplicate test * more examples missed in previous commit --------- Co-authored-by: lcawl <lcawley@elastic.co>
* expand model to include language versions of examples * add language client examples to YAML files * use $ELASTICSEARCH_URL in curl examples * remove unnecessary generate-language-examples task from the openapi generation * upgrade request converter to latest
815a9d1
to
54990f5
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4603-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d3adaadc99f6860c719ed4f304b55f6003e74c0
# Push it to GitHub
git push --set-upstream origin backport-4603-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
* Add request details to examples (#4445) * add request heading line to request examples * add request heading line to response examples * changes to the compiler to include the request heading * add example requests for endpoints that do not use bodies (#4489) * add a few example requests for endpoints that do not use bodies * Remove x-codeSamples from overlay * restructure existing examples w/o bodies as request examples * skip examples w/o bodies when generating openapi examples * add a lot of missing examples * remove duplicate test * more examples missed in previous commit --------- Co-authored-by: lcawl <lcawley@elastic.co> * add language client examples to YAML files (#4514) * expand model to include language versions of examples * add language client examples to YAML files * use $ELASTICSEARCH_URL in curl examples * remove unnecessary generate-language-examples task from the openapi generation * upgrade request converter to latest * Only add x-codeSamples extensions to docs builds of openapi (#4582) * address example errors --------- Co-authored-by: lcawl <lcawley@elastic.co>
This PR is a backport of all the example related changes implemented to date in
main
and9.0
to 8.19.