Skip to content

[8.18] Output a redirect map when merging multipath operations (#4545) #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 16, 2025

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

@pquentin
Copy link
Member

I believe we need to run make compiler-wasm-lib in compiler-rs, but I don't understand the error:

❯ make compiler-wasm-lib
wasm-pack build --release -t nodejs compiler-wasm-lib
[WARN]: ⚠️   "package.metadata.wasm-pack.profile.release.?.codegen-units" is an unknown key and will be ignored. Please check your Cargo.toml.
[WARN]: ⚠️   "package.metadata.wasm-pack.profile.release.?.lto" is an unknown key and will be ignored. Please check your Cargo.toml.
[WARN]: ⚠️   "package.metadata.wasm-pack.profile.release.?.opt-level" is an unknown key and will be ignored. Please check your Cargo.toml.
[INFO]: 🎯  Checking for the Wasm target...
Error: wasm32-unknown-unknown target not found in sysroot: "/opt/homebrew/Cellar/rust/1.87.0"

Used rustc from the following path: "/opt/homebrew/bin/rustc"
It looks like Rustup is not being used. For non-Rustup setups, the wasm32-unknown-unknown target needs to be installed manually. See https://rustwasm.github.io/wasm-pack/book/prerequisites/non-rustup-setups.html on how to do this.

Caused by: wasm32-unknown-unknown target not found in sysroot: "/opt/homebrew/Cellar/rust/1.87.0"

Used rustc from the following path: "/opt/homebrew/bin/rustc"
It looks like Rustup is not being used. For non-Rustup setups, the wasm32-unknown-unknown target needs to be installed manually. See https://rustwasm.github.io/wasm-pack/book/prerequisites/non-rustup-setups.html on how to do this.

make: *** [compiler-wasm-lib] Error 1

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin
Copy link
Member

Trying to get CI to run...

@pquentin pquentin closed this Jun 17, 2025
@pquentin pquentin reopened this Jun 17, 2025
@lcawl lcawl force-pushed the backport/8.18/pr-4545 branch from ff7a8fc to dd96125 Compare June 17, 2025 15:22
@lcawl lcawl merged commit 6a54334 into 8.18 Jun 17, 2025
7 checks passed
@lcawl lcawl deleted the backport/8.18/pr-4545 branch June 17, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants