Skip to content

[Backport 8.18] Fix AsyncQueryResuest - those parameters should be in the body (#4517) #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

[Backport 8.18] Fix AsyncQueryResuest - those parameters should be in the body (#4517) #4569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 7 additions & 30 deletions output/openapi/elasticsearch-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

67 changes: 27 additions & 40 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions output/schema/validation-errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,6 @@
],
"response": []
},
"esql.async_query": {
"request": [
"Request: query parameter 'keep_alive' does not exist in the json spec",
"Request: query parameter 'keep_on_completion' does not exist in the json spec",
"Request: query parameter 'wait_for_completion_timeout' does not exist in the json spec"
],
"response": []
},
"get_source": {
"request": [
"Request: query parameter 'stored_fields' does not exist in the json spec"
Expand Down
5 changes: 2 additions & 3 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 14 additions & 22 deletions specification/esql/async_query/AsyncQueryRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,28 +53,6 @@ export interface Request extends RequestBase {
* A short version of the Accept header, for example `json` or `yaml`.
*/
format?: EsqlFormat
/**
* The period for which the query and its results are stored in the cluster.
* The default period is five days.
* When this period expires, the query and its results are deleted, even if the query is still ongoing.
* If the `keep_on_completion` parameter is false, Elasticsearch only stores async queries that do not complete within the period set by the `wait_for_completion_timeout` parameter, regardless of this value.
* @server_default 5d
*/
keep_alive?: Duration
/**
* Indicates whether the query and its results are stored in the cluster.
* If false, the query and its results are stored in the cluster only if the request does not complete during the period set by the `wait_for_completion_timeout` parameter.
* @server_default false
*/
keep_on_completion?: boolean
/**
* The period to wait for the request to finish.
* By default, the request waits for 1 second for the query results.
* If the query completes during this period, results are returned
* Otherwise, a query ID is returned that can later be used to retrieve the results.
* @server_default 1s
*/
wait_for_completion_timeout?: Duration
}
/**
* Use the `query` element to start a query. Use `time_zone` to specify an execution time zone and `columnar` to format the answer.
Expand Down Expand Up @@ -129,5 +107,19 @@ export interface Request extends RequestBase {
* @server_default 1s
*/
wait_for_completion_timeout?: Duration
/**
* The period for which the query and its results are stored in the cluster.
* The default period is five days.
* When this period expires, the query and its results are deleted, even if the query is still ongoing.
* If the `keep_on_completion` parameter is false, Elasticsearch only stores async queries that do not complete within the period set by the `wait_for_completion_timeout` parameter, regardless of this value.
* @server_default 5d
*/
keep_alive?: Duration
/**
* Indicates whether the query and its results are stored in the cluster.
* If false, the query and its results are stored in the cluster only if the request does not complete during the period set by the `wait_for_completion_timeout` parameter.
* @server_default false
*/
keep_on_completion?: boolean
}
}