-
Notifications
You must be signed in to change notification settings - Fork 102
Add search_application.render_query #3401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
specification/search_application/render_query/SearchApplicationsRenderQueryRequest.ts
Outdated
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3401-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5b89ab2cfd7961c3d82953df1b7a070234441f9
# Push it to GitHub
git push --set-upstream origin backport-3401-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3401-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5b89ab2cfd7961c3d82953df1b7a070234441f9
# Push it to GitHub
git push --set-upstream origin backport-3401-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
* Add search_application.render_query * Add doc_id * Fix request body --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5b89ab) # Conflicts: # docs/overlays/elasticsearch-openapi-overlays.yaml
* Add search_application.render_query * Add doc_id * Fix request body --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5b89ab) # Conflicts: # docs/overlays/elasticsearch-openapi-overlays.yaml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Add search_application.render_query * Add doc_id * Fix request body --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5b89ab) # Conflicts: # docs/overlays/elasticsearch-openapi-overlays.yaml Co-authored-by: Lisa Cawley <lcawley@elastic.co>
* Add search_application.render_query * Add doc_id * Fix request body --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5b89ab) # Conflicts: # docs/overlays/elasticsearch-openapi-overlays.yaml Co-authored-by: Lisa Cawley <lcawley@elastic.co>
export interface Request extends RequestBase { | ||
path_parts: { | ||
/** | ||
* The name of the search application to render teh query for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: the
*/ | ||
|
||
export class Response { | ||
body: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Do we somewhere track these cases where we only defined a request, but not a proper response?
Doing it like this will suppress the compiler warning about missing request/response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Does this mean it's preferable to omit the response file entirely when we don't know the contents of the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing it like this will suppress the compiler warning about missing request/response.
I'm also surprised that make validate
passed, which is why I did not realize that the body was missing.
Good point. Does this mean it's preferable to omit the response file entirely when we don't know the contents of the body?
Ideally, yes, but it breaks the OpenAPI transformation right now.
Relates to #3377
This PR adds a missing specification based on https://www.elastic.co/guide/en/elasticsearch/reference/master/search-application-render-query.html