Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch from java issues #2412

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Batch from java issues #2412

merged 9 commits into from
Feb 19, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Feb 8, 2024

Fixes provided in this PR:

  • 727 added remove_binary to AttachmentProcessor
  • 242 made NodeInfoPath and seed_hosts optional to make the method .nodes().info() work properly, also made initial_master_nodes a string array, since the documentation allows for both a single string and an array, also added additional properties for NodeInfoDiscover
  • 315 fixed description for update by query
  • 299 allowed custom options for IndexSettings Similarity (via custom plugin)

@l-trotta l-trotta requested a review from swallez February 8, 2024 14:37
@l-trotta l-trotta requested a review from a team as a code owner February 8, 2024 14:37
@l-trotta l-trotta added backport 7.17 lang:java Affects/found in the Java client labels Feb 8, 2024
specification/nodes/info/types.ts Outdated Show resolved Hide resolved
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block 🟢 2/2 2/2
indices.analyze 🟢 20/20 20/20
indices.clear_cache 🟢 4/4 4/4
indices.clone 🟢 5/5 5/5
indices.close 🔴 46/46 45/46
indices.create_data_stream 🔴 28/28 27/28
indices.create 🔴 815/830 826/830
indices.data_streams_stats 🟢 4/4 4/4
indices.delete_alias 🔴 15/15 11/15
indices.delete_data_lifecycle Missing test Missing test
indices.delete_data_stream 🔴 28/28 26/28
indices.delete_index_template 🟢 1/1 1/1
indices.delete_template 🟢 9/9 9/9
indices.delete 🔴 104/104 100/104
indices.disk_usage 🟢 5/5 5/5
indices.downsample 🟢 1/1 1/1
indices.exists_alias 🟢 36/36 36/36
indices.exists_index_template Missing test Missing test
indices.exists_template 🟢 15/15 15/15
indices.exists 🟢 39/39 39/39
indices.explain_data_lifecycle Missing test Missing test
indices.field_usage_stats 🟢 5/5 5/5
indices.flush 🟢 10/10 10/10
indices.forcemerge 🔴 5/5 4/5
indices.get_alias 🔴 83/83 70/83
indices.get_data_lifecycle Missing test Missing test
indices.get_data_stream 🔴 12/12 2/12
indices.get_field_mapping 🔴 15/15 13/15
indices.get_index_template 🔴 18/18 1/18
indices.get_mapping 🔴 90/90 80/90
indices.get_settings 🔴 56/56 54/56
indices.get_template 🟢 30/30 30/30
indices.get 🔴 53/53 41/53
indices.migrate_to_data_stream Missing test Missing test
indices.modify_data_stream Missing test Missing test
indices.open 🟢 18/18 18/18
indices.promote_data_stream Missing test Missing test
indices.put_alias 🟢 56/56 56/56
indices.put_data_lifecycle Missing test Missing test
indices.put_index_template 🔴 47/50 47/50
indices.put_mapping 🔴 73/74 73/74
indices.put_settings 🔴 54/57 57/57
indices.put_template 🔴 40/46 42/46
indices.recovery 🔴 9/9 8/9
indices.refresh 🟢 230/230 230/230
indices.reload_search_analyzers 🟢 2/2 2/2
indices.resolve_index 🔴 6/6 5/6
indices.rollover 🟢 26/26 26/26
indices.segments 🔴 6/6 4/6
indices.shard_stores 🔴 5/5 3/5
indices.shrink 🟢 5/5 5/5
indices.simulate_index_template 🟢 7/7 7/7
indices.simulate_template 🔴 5/5 4/5
indices.split 🟢 11/11 11/11
indices.stats 🔴 101/101 32/100
indices.unfreeze 🟢 1/1 1/1
indices.update_aliases 🔴 22/22 21/22
indices.validate_query 🟢 7/7 7/7
ingest.delete_pipeline 🟢 11/11 11/11
ingest.geo_ip_stats Missing test Missing test
ingest.get_pipeline 🔴 22/22 6/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_pipeline 🔴 33/42 40/42
ingest.simulate 🔴 0/7 6/7
nodes.info 🔴 109/109 1/109

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit d792c32 into main Feb 19, 2024
6 checks passed
@l-trotta l-trotta deleted the java-client-issues-fixes branch February 19, 2024 15:29
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2412-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d792c326a393769cc783482cf209435750d45029
# Push it to GitHub
git push --set-upstream origin backport-2412-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2412-to-7.17.

l-trotta added a commit that referenced this pull request Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)
@l-trotta l-trotta mentioned this pull request Feb 19, 2024
l-trotta added a commit that referenced this pull request Feb 19, 2024
* Batch from java issues (#2412)

* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)

* contrib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.17 lang:java Affects/found in the Java client specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants