Create platform specific run-elasticsearch task #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits out the command and script/script runner elements of the run-elasticsearch task to fix a bug when running on Windows where the task on linux and macOS uses a command whilst windows uses a script to run via WSL2. The Windows specific task ends up with multiple actions (command and script) which cargo make errors on.
|
Merging in - test failures unrelated to this change. |
russcam
added a commit
that referenced
this pull request
Jan 27, 2021
This commit splits out the command and script/script runner elements of the run-elasticsearch task to fix a bug when running on Windows where the task on linux and macOS uses a command whilst windows uses a script to run via WSL2. The Windows specific task ends up with multiple actions (command and script) which cargo make errors on. (cherry picked from commit 65093c7)
russcam
added a commit
that referenced
this pull request
Jan 27, 2021
This commit splits out the command and script/script runner elements of the run-elasticsearch task to fix a bug when running on Windows where the task on linux and macOS uses a command whilst windows uses a script to run via WSL2. The Windows specific task ends up with multiple actions (command and script) which cargo make errors on. (cherry picked from commit 65093c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits out the command and script/script runner elements of the run-elasticsearch task to fix a bug when running on Windows where the task on Linux and macOS uses a command whilst Windows uses a script to run via WSL2. The Windows specific
task ends up with multiple actions (command and script) which cargo make errors on.