Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Indexer README to work with ES 7+ #968

Closed
wants to merge 1 commit into from

Conversation

dixpac
Copy link

@dixpac dixpac commented Dec 6, 2020

Old Indexer example doesn't work on ES 7. Main problem is specifying
type inside Client.index.

This PR changes the example to work.

Connected to #967

Old Indexer example doesn't work on ES 7. Main problem is specifying
`type` inside `Client.index`.

This PR changes the example to work.
@cla-checker-service
Copy link

cla-checker-service bot commented Dec 6, 2020

💚 CLA has been signed

@picandocodigo
Copy link
Member

Hi @dixpac,
Thank you for this contribution! Can you sign the Contributor Agreement please?

We may instead want to just stop using type at all in the example in the README since it's been deprecated. I'll take a look to update any more places where we're referring to type when using 7.x versions of the stack.

@picandocodigo picandocodigo added the waiting-for-user Waiting for user input to proceed label Mar 5, 2021
@dixpac
Copy link
Author

dixpac commented Mar 5, 2021

@picandocodigo no problem, signed!

@picandocodigo picandocodigo added pinned and removed waiting-for-user Waiting for user input to proceed labels Mar 9, 2021
@Quicks
Copy link

Quicks commented Nov 12, 2021

Hi @dixpac
Maybe also we need to call IndexerWorker after commit changes to database
Cause in postgres with json field I had an issue with that

after_commit { ElasticSearch::IndexerWorker.perform_async((persisted? ? :index : :delete), self.class.to_s, self.id) }

@dixpac dixpac closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants