Skip to content

ssl_show_warn option added #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2019
Merged

ssl_show_warn option added #913

merged 2 commits into from
Mar 28, 2019

Conversation

alvarolmedo
Copy link
Contributor

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost
Copy link

ghost commented Mar 15, 2019

Hi @alvarolmedo, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@alvarolmedo
Copy link
Contributor Author

email added

@alvarolmedo
Copy link
Contributor Author

Closes issue #914

@alvarolmedo
Copy link
Contributor Author

does this PR be right yet?

@fxdgear
Copy link
Contributor

fxdgear commented Mar 25, 2019

jenkins test this please

@alvarolmedo
Copy link
Contributor Author

Hi again,
I've check the links to your CI and the matrix a jobs executed and failed:
https://clients-ci.elastic.co/job/elastic+elasticsearch-py+pull-request/33/
About the tests with python2.7 and ES version 6.0.1 works fine in my local:

(.venv) aolmedo@guybrush:~/Repos/elasticsearch-py/test_elasticsearch$ python --version
Python 2.7.15rc1
(.venv) aolmedo@guybrush:~/Repos/elasticsearch-py/test_elasticsearch$ python run_tests.py 
No elasticsearch repo found...
........................../home/aolmedo/Repos/elasticsearch-py/elasticsearch/client/utils.py:50: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  quote_plus(_escape(p), b',*') for p in parts if p not in SKIP_IN_PATH)
............................................................................................................
----------------------------------------------------------------------
Ran 134 tests in 30.944s

OK
Shutting down....
(.venv) aolmedo@guybrush:~/Repos/elasticsearch-py/test_elasticsearch$ curl http://localhost:9200
{
  "name" : "SmJ6n1V",
  "cluster_name" : "docker-cluster",
  "cluster_uuid" : "S0HvL03FRW-PbKUNLAR2tw",
  "version" : {
    "number" : "6.0.1",
    "build_hash" : "601be4a",
    "build_date" : "2017-12-04T09:29:09.525Z",
    "build_snapshot" : false,
    "lucene_version" : "7.0.1",
    "minimum_wire_compatibility_version" : "5.6.0",
    "minimum_index_compatibility_version" : "5.0.0"
  },
  "tagline" : "You Know, for Search"
}

Could be a partial o temporal error?

About the errors in python 3.3 all of them have the same origin: error in your deps:

19:53:56 PyYAML requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the running Python is 3.3.7
19:53:56 You are using pip version 9.0.1, however version 19.0.3 is available.
19:53:56 You should consider upgrading via the 'pip install --upgrade pip' command.
19:53:56 Service 'client' failed to build: The command '/bin/sh -c pip install .[develop]' returned a non-zero code: 1
19:53:56 make: *** [run_tests] Error 1

@fxdgear
Copy link
Contributor

fxdgear commented Mar 28, 2019

Python3.3 is EOL and as such this entry in the matrix is going away. I'll be removing it from the test matrix in the es-7 PR.

@fxdgear
Copy link
Contributor

fxdgear commented Mar 28, 2019

re your python27 failure:

12:56:04 
12:56:04 ======================================================================
12:56:04 FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk)
12:56:04 ----------------------------------------------------------------------
12:56:04 Traceback (most recent call last):
12:56:04   File "/usr/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
12:56:04     return func(*args, **keywargs)
12:56:04   File "/code/elasticsearch-py/test_elasticsearch/test_helpers.py", line 34, in test_all_chunks_sent
12:56:04     self.assertEquals(50, _process_bulk_chunk.call_count)
12:56:04 AssertionError: 50 != 49

This is a result of the fact that mock is not thread safe and this test runs using multi threading. It's really annoying :(

@fxdgear
Copy link
Contributor

fxdgear commented Mar 28, 2019

Thanks for the patch and the tests.

@fxdgear fxdgear merged commit 51ad5d3 into elastic:master Mar 28, 2019
@alvarolmedo
Copy link
Contributor Author

I see the error of the mock in your jenkins execution, but in my local works fine... :o

@alvarolmedo
Copy link
Contributor Author

Thanks for accept the PR, when a new release it's scheduled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants