Skip to content

Add the recent mypy fix to field.py to the template for this file #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

miguelgrinberg
Copy link
Contributor

This typing fix was incorrectly added to dsl/field.py. I missed that this file is generated, so its template should be fixed as well.

@miguelgrinberg miguelgrinberg requested a review from pquentin June 4, 2025 11:20
@miguelgrinberg miguelgrinberg merged commit e616da9 into elastic:main Jun 4, 2025
18 checks passed
@miguelgrinberg miguelgrinberg deleted the fix-field-py-template branch June 4, 2025 11:38
Copy link

github-actions bot commented Jun 4, 2025

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-2979-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e616da96335f59849e193716132de8769acc9813
# Push it to GitHub
git push --set-upstream origin backport-2979-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-2979-to-8.17.

github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
miguelgrinberg added a commit that referenced this pull request Jun 4, 2025
) (#2982)

(cherry picked from commit e616da9)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Jun 4, 2025
) (#2980)

(cherry picked from commit e616da9)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit that referenced this pull request Jun 4, 2025
miguelgrinberg added a commit that referenced this pull request Jun 4, 2025
) (#2981)

(cherry picked from commit e616da9)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant