Skip to content

Bulk Helper: Actions params whitelist is missing if_seq_no and if_primary_term #1259

Closed
@USSRLivesOn

Description

@USSRLivesOn

Elasticsearch version (bin/elasticsearch --version):
7.4.2

elasticsearch-py version (elasticsearch.__versionstr__):
7.5.1, but as far as I can tell, bug is still in master.

Description of the problem including expected versus actual behavior:
The bulk helper should respect the if_seq_no and if_primary_term parameters in the action, but it does not. As far as I can tell, they're just ignored entirely because they're not included in the expand_action whitelist. They should be included in the whitelist.

Steps to reproduce:
Use the bulk helper with the if_seq_no and if_primary_term params. Notice that they don't actually get sent to the cluster.


Separately, it'd be really nice if the bulk helper didn't just silently ignore unrecognized attributes. If you're whitelisting the valid params, then I'd expect at least a warning logged that an unrecognized param was encountered. An error would be even better.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions