Code refactor + updated endpoints for 7.0.0 #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been tested in ezimuel/feature/7.0.0 branch. See comments here. |
marcvdm
reviewed
Jun 14, 2019
|
|
||
| $this->body['scroll_id'] = $scroll_id; | ||
| if (isset($scrollId)) { | ||
| return "/_search/scroll/$scrollId"; |
There was a problem hiding this comment.
I can't seem to find where this is documented for es 7.x. Tried the 7.0 release version with es 7.2 but the scrollId is not picked up by elasticsearch.
There was a problem hiding this comment.
The API specification for scroll endpoint, using ES 7.0.0, is reported here. If you are using ES 7.2 the /_search/scroll/$scrollId has been deprecated, see here.
I'll release elasticsearch-php 7.1 soon and I need to manage some deprecated paths for ES 7.2, that will be released soon (current master of elastic/elasticsearch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the code refactor (with type hints + some minor internal changes) and the endpoints update for ES 7.0.0. Moreover, it requires PHP 7.1 as minimum version in
composer.json.