-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] References shared/version and adds doctype to index file #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabosteve
changed the title
[DOCS] Adds doctype to index file.
[DOCS] References shared/version and adds doctype to index file
Feb 9, 2023
ezimuel
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some tests are failing but they are not related to this PR.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
szabosteve
added a commit
to szabosteve/elasticsearch-php
that referenced
this pull request
Feb 10, 2023
…tic#1280) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 10, 2023
ezimuel
pushed a commit
that referenced
this pull request
Feb 10, 2023
… (#1282) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 10, 2023
… (#1283) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 10, 2023
… (#1284) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 10, 2023
… (#1288) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 13, 2023
… (#1287) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 13, 2023
… (#1286) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
ezimuel
pushed a commit
that referenced
this pull request
Feb 14, 2023
… (#1285) * [DOCS] Adds doctype to index file. * [DOCS] Adds shared/versions to include in index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to https://github.com/elastic/clients-team/issues/532.
This PR references
shared/version
from the docs repo to make it possible to use the{branch}
substitution, and addsdoctype: book
to the index file. It also changes a link to use{branch}
instead ofmaster
.