Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x][DOCS] Adds discrete attributes to section titles #1099

Merged
merged 1 commit into from
Feb 16, 2021
Merged

[7.x][DOCS] Adds discrete attributes to section titles #1099

merged 1 commit into from
Feb 16, 2021

Conversation

szabosteve
Copy link
Contributor

Overview

This PR adds the discrete attribute to every third and fourth level section in the PHP docs. This way these sections won't be chunked into new pages after elastic/docs#2043 merged.

@szabosteve szabosteve requested a review from ezimuel January 21, 2021 16:38
@szabosteve szabosteve mentioned this pull request Jan 21, 2021
Merged
ezimuel
ezimuel approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ezimuel ezimuel merged commit 30e6af9 into elastic:7.x Feb 16, 2021
@szabosteve szabosteve deleted the 7.x.chunking branch February 16, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimuel ezimuel ezimuel approved these changes

Assignees
No one assigned
Labels
7.x Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabosteve @ezimuel