(Doc+) Add typed_keys parameter set as true #8605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description This PR Add `typed_keys` parameter set as `true`: - a `JsonException` that occurs when using aggregations with `SearchTemplateAsync` because the mandatory `typed_keys=true` parameter is undocumented. - This change improves the developer experience by preventing user confusion and saving significant debugging time when using search templates. ### Related issues - #7605 (comment) - elastic/sdh-search#1648 (comment)
|
Hi @jihyunjeongme thanks a lot for creating this PR. Much appreciated 🙂 We checked again and it seems that we can safely set |
|
Closed in favor of #8609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Add
typed_keysparameter set astrue:JsonExceptionthat occurs when using aggregations withSearchTemplateAsyncbecause the mandatorytyped_keys=trueparameter is undocumented.Related issues