Skip to content

Add empty_value parameter to CSV processor #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Conversation

codebrain
Copy link
Contributor

Adds an empty_value parameter to the CSV processor:
https://www.elastic.co/guide/en/elasticsearch/reference/master/csv-processor.html

@codebrain codebrain requested a review from russcam April 16, 2020 03:47
@codebrain codebrain mentioned this pull request Apr 16, 2020
38 tasks
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM do we want to update the test for the processor in tests/Tests/Ingest/ProcessorAssertions.cs too?

@codebrain codebrain merged commit 76f412a into 7.7 Apr 17, 2020
@codebrain codebrain deleted the feature/7.7/csv-empty-value branch April 17, 2020 04:23
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
Add empty_value parameter to CSV processor
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
Add empty_value parameter to CSV processor
codebrain added a commit that referenced this pull request Apr 17, 2020
Add empty_value parameter to CSV processor

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>
codebrain added a commit that referenced this pull request Apr 17, 2020
Add empty_value parameter to CSV processor

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants