Skip to content

Add max_children to Nested Sort #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add max_children to Nested Sort #4596

merged 1 commit into from
Apr 17, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 16, 2020

This commit adds max_children to nested sort.

Closes #4595

@russcam
Add max_children to Nested Sort
db77e15 
This commit adds max_children to nested sort.

Closes #4595
Mpdreamz
Mpdreamz approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will this need a SkipVersion when backporting to 6.x?

@russcam
Copy link
Contributor Author

russcam commented Apr 17, 2020 •
edited
Loading

LGTM, will this need a SkipVersion when backporting to 6.x?

Yes, it needs a

[SkipVersion("<6.5.0", "introduced in 6.5.0")]

will manual backport because of the json serializer attributes too

@russcam russcam merged commit 7aa05d9 into master Apr 17, 2020
@russcam russcam deleted the feature/nested-max-children branch April 17, 2020 05:08
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
@russcam @github-actions
Add max_children to Nested Sort (#4596)
3110d3e 
This commit adds max_children to nested sort.

Closes #4595
@github-actions github-actions bot mentioned this pull request Apr 17, 2020
Merged
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
@russcam @github-actions
Add max_children to Nested Sort (#4596)
f50c311 
This commit adds max_children to nested sort.

Closes #4595
@github-actions github-actions bot mentioned this pull request Apr 17, 2020
Merged
russcam added a commit that referenced this pull request Apr 17, 2020
@russcam
Add max_children to Nested Sort (#4596) (#4628)
f2963e0 
This commit adds max_children to nested sort.

Closes #4595

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Apr 17, 2020
@russcam
Add max_children to Nested Sort (#4596)
4891909 
This commit adds max_children to nested sort.

Closes #4595

(cherry picked from commit 7aa05d9)
russcam added a commit that referenced this pull request May 7, 2020
@russcam
Add max_children to Nested Sort (#4596)
1f01f26 
This commit adds max_children to nested sort.

Closes #4595

(cherry picked from commit 3110d3e)
@russcam russcam added v7.6.2 and removed v7.7.0 labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add max_children to nested sort
2 participants
@russcam @Mpdreamz