Skip to content

implement IPercentageScoreHeuristic on PercentageScoreHeuristic #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 9, 2020

This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573

This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backport 7.6 is not needed though.

@russcam russcam merged commit 0defcd5 into 7.x Apr 17, 2020
@russcam russcam deleted the fix/4573 branch April 17, 2020 04:56
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573
russcam added a commit that referenced this pull request Apr 17, 2020
… (#4626)

This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Apr 17, 2020
… (#4627)

This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request May 7, 2020
This commit implements IPercentageScoreHeuristic on
PercentageScoreHeuristic in order to fix an exception
when attempting to serialize PercentageScore on
SignificantTerms aggregation.

Fixes #4573

(cherry picked from commit 2b04aa1)
@russcam russcam added v7.6.2 and removed v7.7.0 labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants