ISO8601TimeSpanFormatter to use local byte[] array, as opposed to renting from pool. #4503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om pool. The minimum buffer size that can be rented from the shared memory pool is 65535 bytes. This amount of memory for the purposes of deserialising the day component of a string timespan is excessive. This commit changes the procedure to use a local byte array.
|
Closed in favor of: #4509 |
codebrain
changed the title
russcam
approved these changes
Mar 27, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
…om pool. (#4503) The minimum buffer size that can be rented from the shared memory pool is 65535 bytes. This amount of memory for the purposes of deserialising the day component of a string timespan is excessive. This commit changes the procedure to use a local byte array.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
…om pool. (#4503) The minimum buffer size that can be rented from the shared memory pool is 65535 bytes. This amount of memory for the purposes of deserialising the day component of a string timespan is excessive. This commit changes the procedure to use a local byte array.
codebrain
added a commit
that referenced
this pull request
Mar 27, 2020
…om pool. (#4503) (#4522) The minimum buffer size that can be rented from the shared memory pool is 65535 bytes. This amount of memory for the purposes of deserialising the day component of a string timespan is excessive. This commit changes the procedure to use a local byte array. Co-authored-by: Stuart Cam <stuart.cam@elastic.co>
codebrain
added a commit
that referenced
this pull request
Mar 27, 2020
…om pool. (#4503) (#4523) The minimum buffer size that can be rented from the shared memory pool is 65535 bytes. This amount of memory for the purposes of deserialising the day component of a string timespan is excessive. This commit changes the procedure to use a local byte array. Co-authored-by: Stuart Cam <stuart.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum buffer size that can be rented from the shared memory pool is 65535 bytes. This amount of memory for the purposes of serializing the day component of a string timespan is excessive. This commit changes the procedure to use a local byte array
Adds test for max size of 64bit value.