Add missing datatype members to IPropertiesDescriptor #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype> This commit adds missing datatype method members to IPropertiesDescriptor<T, out TReturnType> interface that were implemented on the concrete implementation PropertiesDescriptor<T>, but not the concrete implementation SingleMappingSelector<T>. Add XML docs to IProperty type
Mpdreamz
approved these changes
Feb 5, 2020
This commit adds conventions tests for IPropertyDescriptor<,> to ensure that there is a descriptor method for all IProperty types, and that the interface IPropertyDescriptor<,> has an IProperty method implementation for all methods defined on PropertyDescriptor<T>
|
I've added a couple of code standards tests |
russcam
added a commit
that referenced
this pull request
Feb 10, 2020
This commit - Adds missing datatype method members to IPropertiesDescriptor<T, out TReturnType> interface that were implemented on the concrete implementation PropertiesDescriptor<T>, but not the concrete implementation SingleMappingSelector<T>. - Adds XML docs to IProperty type - Adds conventions tests for IPropertyDescriptor<,> to ensure that there is a descriptor method for all IProperty types, and that the interface IPropertyDescriptor<,> has an IProperty method implementation for all methods defined on PropertyDescriptor<T> (cherry picked from commit 07bfc0a)
|
ported to master a50f8a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing datatype method members to
IPropertiesDescriptor<T, out TReturnType>interface that were implemented on the concrete implementation
PropertiesDescriptor<T>,but not the concrete implementation
SingleMappingSelector<T>.Add XML docs to IProperty types