Skip to content

Handle short form queries #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ internal static class FromJson
/// </summary>
public static T ReadAs<T>(JsonReader reader, JsonSerializer serializer)
{
var t = (T)typeof(T).CreateInstance();
var t = typeof(T).CreateInstance<T>();
serializer.Populate(reader, t);
return t;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,39 @@ internal class FieldNameQueryJsonConverter<TReadAs> : ReserializeJsonConverter<T
{
protected override object DeserializeJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
{
//{
reader.Read(); //property name
var fieldName = reader.Value as string;
reader.Read(); //{
var query = ReadAs(reader, objectType, existingValue, serializer);
var fieldName = (string)reader.Value;
reader.Read();
TReadAs query = null;

if (query == null) return null;
switch (reader.TokenType)
{
case JsonToken.StartObject:
query = ReadAs(reader, objectType, existingValue, serializer);
break;
case JsonToken.Null:
break;
default:
query = new TReadAs();
switch (query)
{
case ITermQuery termQuery:
termQuery.Value = reader.Value;
break;
case IMatchQuery matchQuery:
matchQuery.Query = (string)reader.Value;
break;
case IMatchPhraseQuery matchPhraseQuery:
matchPhraseQuery.Query = (string)reader.Value;
break;
case IMatchPhrasePrefixQuery matchPhrasePrefixQuery:
matchPhrasePrefixQuery.Query = (string)reader.Value;
break;
}
break;
}

if (query == null) return null;
query.Field = fieldName;

return query;
Expand Down
15 changes: 14 additions & 1 deletion src/Tests/Tests/QueryDsl/FullText/Match/MatchUsageTests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
using Nest;
using System.IO;
using Elastic.Xunit.XunitPlumbing;
using FluentAssertions;
using Nest;
using Tests.Core.ManagedElasticsearch.Clusters;
using Tests.Domain;
using Tests.Framework.Integration;
Expand Down Expand Up @@ -69,5 +72,15 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
.FuzzyRewrite(MultiTermQueryRewrite.TopTermsBlendedFreqs(10))
.Name("named_query")
);

//hide
[U] public void DeserializeShortForm()
{
using var stream = new MemoryStream(ShortFormQuery);
var query = Client.RequestResponseSerializer.Deserialize<IMatchQuery>(stream);
query.Should().NotBeNull();
query.Field.Should().Be(new Field("description"));
query.Query.Should().Be("project description");
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
using Nest;
using System.IO;
using Elastic.Xunit.XunitPlumbing;
using FluentAssertions;
using Nest;
using Tests.Core.ManagedElasticsearch.Clusters;
using Tests.Domain;
using Tests.Framework.Integration;
Expand Down Expand Up @@ -51,5 +54,15 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
.Slop(2)
.Name("named_query")
);

//hide
[U] public void DeserializeShortForm()
{
using var stream = new MemoryStream(ShortFormQuery);
var query = Client.RequestResponseSerializer.Deserialize<IMatchPhraseQuery>(stream);
query.Should().NotBeNull();
query.Field.Should().Be(new Field("description"));
query.Query.Should().Be("project description");
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
using Nest;
using System.IO;
using Elastic.Xunit.XunitPlumbing;
using FluentAssertions;
using Nest;
using Tests.Core.ManagedElasticsearch.Clusters;
using Tests.Domain;
using Tests.Framework.Integration;
Expand Down Expand Up @@ -54,5 +57,15 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
.Slop(2)
.Name("named_query")
);

//hide
[U] public void DeserializeShortForm()
{
using var stream = new MemoryStream(ShortFormQuery);
var query = Client.RequestResponseSerializer.Deserialize<IMatchPhrasePrefixQuery>(stream);
query.Should().NotBeNull();
query.Field.Should().Be(new Field("description"));
query.Query.Should().Be("project description");
}
}
}
4 changes: 4 additions & 0 deletions src/Tests/Tests/QueryDsl/QueryDslUsageTestsBase.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using System;
using System.Text;
using System.Threading.Tasks;
using Elastic.Xunit.XunitPlumbing;
using Elasticsearch.Net;
using FluentAssertions;
using Nest;
using Newtonsoft.Json;
using Tests.Core.Client;
using Tests.Core.Extensions;
using Tests.Core.ManagedElasticsearch.Clusters;
Expand All @@ -20,6 +22,8 @@ public abstract class QueryDslUsageTestsBase

protected readonly QueryContainer VerbatimQuery = new QueryContainer(new TermQuery { IsVerbatim = true });

protected byte[] ShortFormQuery => Encoding.UTF8.GetBytes(JsonConvert.SerializeObject(new { description = "project description" }));

protected QueryDslUsageTestsBase(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }

protected virtual ConditionlessWhen ConditionlessWhen => null;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
using System.IO;
using Elastic.Xunit.XunitPlumbing;
using FluentAssertions;
using Nest;
using Tests.Core.ManagedElasticsearch.Clusters;
using Tests.Domain;
using Tests.Framework.Integration;

namespace Tests.QueryDsl.PrefixLevel.Prefix
namespace Tests.QueryDsl.TermLevel.Prefix
{
public class PrefixQueryUsageTests : QueryDslUsageTestsBase
{
Expand Down Expand Up @@ -47,5 +50,15 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
.Value("proj")
.Rewrite(MultiTermQueryRewrite.TopTerms(10))
);

//hide
[U] public void DeserializeShortForm()
{
using var stream = new MemoryStream(ShortFormQuery);
var query = Client.RequestResponseSerializer.Deserialize<IPrefixQuery>(stream);
query.Should().NotBeNull();
query.Field.Should().Be(new Field("description"));
query.Value.Should().Be("project description");
}
}
}
13 changes: 13 additions & 0 deletions src/Tests/Tests/QueryDsl/TermLevel/Term/TermQueryUsageTests.cs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
using System.IO;
using Elastic.Xunit.XunitPlumbing;
using FluentAssertions;
using Nest;
using Tests.Core.ManagedElasticsearch.Clusters;
using Tests.Domain;
Expand Down Expand Up @@ -44,6 +47,16 @@ protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project>
.Field(p => p.Description)
.Value("project description")
);

//hide
[U] public void DeserializeShortForm()
{
using var stream = new MemoryStream(ShortFormQuery);
var query = Client.RequestResponseSerializer.Deserialize<ITermQuery>(stream);
query.Should().NotBeNull();
query.Field.Should().Be(new Field("description"));
query.Value.Should().Be("project description");
}
}

/**[float]
Expand Down