Get highest AssemblyFileVersionAttribute version #4270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the FrameworkDescription logic used to determine the .NET framework version from the AssemblyFileVersionAttribute on the assembly containing the base object type to 1. Get all AssemblyFileVersionAttribute attributes 2. order by versioning descending 3. get the first version This is to workaround an edge case in using this technique to get the .NET Framework version that appears to affect running an application under full framework in IIS. Fixes #4189.
russcam
added a commit
that referenced
this pull request
Dec 16, 2019
This commit updates the FrameworkDescription logic used to determine the .NET framework version from the AssemblyFileVersionAttribute on the assembly containing the base object type to 1. Get all AssemblyFileVersionAttribute attributes 2. order by versioning descending 3. get the first version This is to workaround an edge case in using this technique to get the .NET Framework version that appears to affect running an application under full framework in IIS. Fixes #4189. (cherry picked from commit 9cf9ce4)
|
ported to master |
mozerov
pushed a commit
to mozerov/elasticsearch-net
that referenced
this pull request
Feb 12, 2020
This commit updates the FrameworkDescription logic used to determine the .NET framework version from the AssemblyFileVersionAttribute on the assembly containing the base object type to 1. Get all AssemblyFileVersionAttribute attributes 2. order by versioning descending 3. get the first version This is to workaround an edge case in using this technique to get the .NET Framework version that appears to affect running an application under full framework in IIS. Fixes elastic#4189.
Mpdreamz
pushed a commit
that referenced
this pull request
Feb 19, 2020
This commit updates the FrameworkDescription logic used to determine the .NET framework version from the AssemblyFileVersionAttribute on the assembly containing the base object type to 1. Get all AssemblyFileVersionAttribute attributes 2. order by versioning descending 3. get the first version This is to workaround an edge case in using this technique to get the .NET Framework version that appears to affect running an application under full framework in IIS. Fixes #4189. Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the FrameworkDescription logic used to determine
the .NET framework version from the AssemblyFileVersionAttribute on the
assembly containing the base object type to
This is to workaround an edge case in using this technique to get the
.NET Framework version that appears to affect running an application
under full framework in IIS.
Fixes #4189.