Serialize dates with min 3 fractional digits when using SourceSeriali… #4175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zer in integration tests This commit adds a new JsonConverter to serialize DateTime/DateTimeOffset with a minimum of 3 fractional digits when running integration tests using the test SourceSerializer. Related to a bug in Elasticsearch <7.1.0 in the XML comment of the JsonConverter. Always emit the random values used when running a test/integrate build, not just if they were explicitly set.
codebrain
approved these changes
Oct 23, 2019
russcam
added a commit
that referenced
this pull request
Oct 23, 2019
…zer in integration tests (#4175) This commit adds a new JsonConverter to serialize DateTime/DateTimeOffset with a minimum of 3 fractional digits when running integration tests using the test SourceSerializer. Related to a bug in Elasticsearch <7.1.0 in the XML comment of the JsonConverter. Always emit the random values used when running a test/integrate build, not just if they were explicitly set. (cherry picked from commit 57a6266)
|
ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zer in integration tests
This commit adds a new JsonConverter to serialize DateTime/DateTimeOffset with a minimum of 3 fractional digits when running integration tests using the test SourceSerializer. Related to a bug in Elasticsearch <7.1.0 in the XML comment of the JsonConverter.
Always emit the random values used when running a test/integrate build, not just if they were explicitly set.
Closes #4167