Skip to content

Add average_search_time_per_bucket_ms and total_bucket_processing_tim… #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions src/Nest/XPack/MachineLearning/Datafeed/DatafeedStats.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,44 @@ namespace Nest
[DataContract]
public class DatafeedStats
{
[DataMember(Name ="assignment_explanation")]
[DataMember(Name = "assignment_explanation")]
public string AssignmentExplanation { get; internal set; }

[DataMember(Name ="datafeed_id")]
[DataMember(Name = "datafeed_id")]
public string DatafeedId { get; internal set; }

[DataMember(Name ="node")]
[DataMember(Name = "node")]
public DiscoveryNode Node { get; internal set; }

[DataMember(Name ="state")]
[DataMember(Name = "state")]
public DatafeedState State { get; internal set; }

[DataMember(Name = "timing_stats")]
public DatafeedTimingStats TimingStats { get; internal set; }
}

[DataContract]
public class DatafeedTimingStats
{
[DataMember(Name = "bucket_count")]
public long BucketCount { get; internal set; }

[DataMember(Name = "exponential_average_search_time_per_hour_ms")]
public double ExponentialAverageSearchTimePerHourMilliseconds { get; internal set; }

[DataMember(Name = "job_id")]
public string JobId { get; internal set; }

[DataMember(Name = "search_count")]
public long SearchCount { get; internal set; }

/// <summary>
/// Total search time in milliseconds
/// </summary>
/// <remarks>
/// Valid only in Elasticsearch 7.4.0+
/// </remarks>
[DataMember(Name = "total_search_time_ms")]
public double TotalSearchTimeMilliseconds { get; internal set; }
}
}
7 changes: 7 additions & 0 deletions src/Nest/XPack/MachineLearning/Job/Config/JobStats.cs
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,13 @@ public class TimingStats
/// </summary>
[DataMember(Name = "exponential_average_bucket_processing_time_ms")]
public double ExponentialAverageBucketProcessingTimeMilliseconds { get; internal set; }

/// <summary>
/// Exponential moving average of all bucket processing times in milliseconds
/// </summary>
/// <remarks>Valid in Elasticsearch 7.4.0+</remarks>
[DataMember(Name = "exponential_average_bucket_processing_time_per_hour_ms")]
public double ExponentialAverageBucketProcessingTimePerHourMilliseconds { get; internal set; }
}

public class JobForecastStatistics
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ protected override void ExpectResponse(GetDatafeedStatsResponse response)
{
response.ShouldBeValid();
response.Count.Should().BeGreaterOrEqualTo(1);
response.Datafeeds.First().State.Should().Be(DatafeedState.Stopped);
var datafeedStats = response.Datafeeds.First();
datafeedStats.State.Should().Be(DatafeedState.Stopped);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

datafeedStats.TimingStats.Should().NotBeNull();
}
}

Expand Down