Skip to content

Deprecate the ability to update datafeed's job_id #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz requested review from russcam and codebrain October 21, 2019 18:50
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@russcam russcam merged commit 785e275 into 7.x Oct 21, 2019
russcam pushed a commit that referenced this pull request Oct 21, 2019
Relates: elastic/elasticsearch#44691

* Deprecate the ability to update datafeed's job_id
* remove deprecated usage of job id in update data_feed tests

(cherry picked from commit 785e275)
@russcam
Copy link
Contributor

russcam commented Oct 21, 2019

ported to master

@Mpdreamz Mpdreamz deleted the fix/7.x/depr-jobid-update-datafeed branch November 6, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants